search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 195 forks source link

Implement .without(predicate) - see #87 #93

Closed holyjak closed 8 years ago

holyjak commented 8 years ago

Exclude all keys/values that satisfy the predicate

Simplify the test by testing primarily without(predicate).

PS: I recommend to also run git co e09e798 test/ImmutableObject/test-without.js; grunt to verify that the old tests before my refactoring still pass (they do for me but you should not trust me :-))

rtfeldman commented 8 years ago

Old tests pass for me too.

Looks great, thanks!

holyjak commented 8 years ago

My pleasure On Thu, 14 Jan 2016 at 17:39, Richard Feldman notifications@github.com wrote:

Old tests pass for me too.

Looks great, thanks!

— Reply to this email directly or view it on GitHub https://github.com/rtfeldman/seamless-immutable/pull/93#issuecomment-171694853 .

rtfeldman commented 8 years ago

@jakubholynet Hm, appears that tests are breaking in Firefox. I fixed some linter errors in the hopes that's all it was, but it appears to be more than that.

Mind taking a look?

holyjak commented 8 years ago

Yes. How to run the tests in FF? On Fri, 15 Jan 2016 at 00:54, Richard Feldman notifications@github.com wrote:

@jakubholynet https://github.com/jakubholynet Hm, appears that tests are breaking in Firefox. I fixed some linter errors in the hopes that's all it was, but it appears to be more than that.

Mind taking a look?

— Reply to this email directly or view it on GitHub https://github.com/rtfeldman/seamless-immutable/pull/93#issuecomment-171820697 .

holyjak commented 8 years ago

Hi @rtfeldman, as mentioned I'd be happy to help with the failing tests but I need you to tell me how to run them :-)

Or have you actually fixed them? The commits seem to indicate that ...

rtfeldman commented 8 years ago

@jakubholynet They are still broken, as far as I can tell. If you run npm run zuul-local and then visit the address printed to the console in Firefox, it will run the tests!

holyjak commented 8 years ago

the pass for me:

seamless-immutable

rtfeldman commented 8 years ago

Ended up getting things fixed. Thanks for the PR! :smile_cat: