search

rtfpessoa / diff2html-cli

Pretty diff to html javascript cli (diff2html-cli)
https://diff2html.xyz
MIT License
524 stars 50 forks source link

ignore.map is not a function #100

Closed whyboris closed 4 years ago

whyboris commented 4 years ago

Currently using the --ig flag does not work:

diff2html --ig package-lock.json

results in:

TypeError: ignore.map is not a function

https://github.com/rtfpessoa/diff2html-cli/blob/1c9b955fe8b1c569499feb248ea81b7f749be154/src/cli.ts#L17

I've not looked into it, just reporting 😅

whyboris commented 4 years ago

🎉 Looked into it, it's just a matter of updating the yargs type 😉 

type: 'array',

instead of nargs: 1, this line: https://github.com/rtfpessoa/diff2html-cli/blob/master/src/yargs.ts#L177

rtfpessoa commented 4 years ago

Released as version 5.1.1