search

rtfpessoa / diff2html

Pretty diff to html javascript library (diff2html)
https://diff2html.xyz
MIT License
2.8k stars 273 forks source link

Initial impl with wontache #446

Open rtfpessoa opened 1 year ago

Lordfirespeed commented 1 year ago

Any updates on this PR? I'm put off using diff2html since hogan.js is so outdated. Happy to contribute if that would be helpful!

rtfpessoa commented 1 year ago

Any updates on this PR?

Not yet.

I'm put off using diff2html since hogan.js is so outdated.

Not sure I understand what is the problem. hogan.js is very stable and no bugs or problems were found. We don't have any special lock on it, we are using mustache and hogan is just the best way I found at the time to render it.

Happy to contribute if that would be helpful!

wontache was pretty early at the time I started this. With the new changes it would require some bigger rewrite and I did not have time. If you want to contribute the migration go ahead and feel free to send a PR.

But TBH wontache has no releases since last October and has no version 1.x. I am ok in releasing some parallel versions but since it is not even stable and has no active development I do not feel comfortable in putting it in master.

geevade commented 1 year ago

We were also looking forward to using diff2html, but then realized, that hogan uses some sort of eval. This conflicts with our csp -> 'call to Function() blocked by CSP' makeTemplate...

Hogan has an unfixed ticket from 10 years ago: https://github.com/twitter/hogan.js/issues/135 their 'solution' didn't work:

'EvalError: Refused to evaluate a string as Javascript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self'" at new Function() at Hogan.makeTemplate