search

rtfpessoa / diff2html

Pretty diff to html javascript library (diff2html)
https://diff2html.xyz
MIT License
2.8k stars 273 forks source link

side-by-side diff is broken in Firefox #475

Closed kuzjka closed 1 year ago

kuzjka commented 1 year ago

Environment

Observed with any diff in side-by-side view

Observed Results:

Side-by-side is rendered wrongly, see screenshot from the demo below:

image

Expected Results:

Side-by-side diff is rendered side-by-side :)

Relevant Code:

After reloading demo page 5 minutes later the issue was gone. I found following differences in the CSS: image left is buggy, right is ok

Looks like the diff2html version on the demo page was changed.

I encountered the issue in my project after migrating from 3.4.17 to 3.4.24, so the issue was introduced somewhere in between.

Sorry for the bitmaps. I can construct specific reproducible example if needed.

jrmuizel commented 1 year ago

For fun, I filed a Firefox bug about it: https://bugzilla.mozilla.org/show_bug.cgi?id=1811353

rtfpessoa commented 1 year ago

Seems like it was introduced by https://github.com/rtfpessoa/diff2html/commit/df005c3f06335c285987e91474b58ef1f2311f1d