rtfpessoa / diff2html

Pretty diff to html javascript library (diff2html)
https://diff2html.xyz
MIT License
2.79k stars 272 forks source link

Add Dark & Auto color schemes #514

Closed JHWelch closed 9 months ago

JHWelch commented 9 months ago
CleanShot 2023-09-26 at 17 56 40@2x

Summary

Fixes #403 Adds support for a colorScheme config value. Possible values are light, dark, and auto.

I left the default value as light trying to reduce the impact on existing users.

~I'm not even a little attached to the colors I used, so please recommend new ones/update them. They are all available as CSS variables.~ Colors updated to match GitHub

Changes to Consider

General Notes

JHWelch commented 9 months ago

Left some minor comments. Overall looks ok. Can you also grab the colors from GitHub I think they have a pretty nice color scheme and it would look better.

Sounds good! Will pull the github colors and update.

Updated to github colors in 987d8cb