search

rth / vtext

Simple NLP in Rust with Python bindings
Apache License 2.0
147 stars 11 forks source link

TST add float_cmp crate for tests #54

Closed jbowles closed 4 years ago

jbowles commented 5 years ago

What would you think about adding float-cmp for doing float comparisons in test?

Clippy complains about float comparisons and I've run into it with other projects...

first time I've tried out this crate to deal with float comparisons in tests.

rth commented 4 years ago

Actually I think the approx crate might be beter, because it will also work with ndarrays in the future https://github.com/rust-ndarray/ndarray/pull/581