search

rth / vtext

Simple NLP in Rust with Python bindings
Apache License 2.0
147 stars 11 forks source link

Sentence tokenization using Unicode segmentation #66

Closed joshlk closed 4 years ago

joshlk commented 4 years ago

Sentence tokenization using Unicode segmentation

Issue: #51

joshlk commented 4 years ago

Odd my local cargo fmt wasn't picking up one of the changes that was making the CI lint fail. My version is 1.4.14-nightly. Should I be using the stable version?

joshlk commented 4 years ago

I am working on adding the new functionality to the Python package. Should I do this on another pull request?

rth commented 4 years ago

Thanks a lot @joshlk !

I am working on adding the new functionality to the Python package. Should I do this on another pull request?

Yes, that would be great thank you!

Odd my local cargo fmt wasn't picking up one of the changes that was making the CI lint fail. My version is 1.4.14-nightly. Should I be using the stable version?

So the linting CI job currently appears to use 1.32.0-nightly we should definitely update it. At the time I created a docker image for that job as I couldn't find an image with both recent versions of rust and Python. I'll look into it.

Otherwise, CI runs tests with,

both could probably be updated..