rthaut / deviantART-Filter

A browser extension that allows you to filter DeviantArt by user, keyword, and/or category.
https://rthaut.github.io/deviantART-Filter/
GNU General Public License v3.0
31 stars 1 forks source link

[v6.0.0] Filters are not Validated/Sanitized #126

Closed rthaut closed 4 years ago

rthaut commented 4 years ago

Currently in version 6.0.0 there is no validation or sensitization of created/updated/imported filters.

This will most likely lead to confused users, as they may enter invalid values (i.e. adding the # for keyword filters, putting invalid characters in usernames, etc.).

Filters should probably be sanitized before being stored (to prevent anything from breaking), but probably more pressing is validation and rejecting invalid filters (with descriptive errors) when adding/editing filters through the datatables.

Since material-table is being used, component overrides will likely be required to accomplish some or all of the following: