search

rthaut / deviantART-Filter

A browser extension that allows you to filter DeviantArt by user, keyword, and/or category.
https://rthaut.github.io/deviantART-Filter/
GNU General Public License v3.0
30 stars 1 forks source link

[v6.1.0] New Create Filters Modal Shows on All Open Pages #140

Closed rthaut closed 4 years ago

rthaut commented 4 years ago

If multiple tabs/windows are open on www.deviantart.com, using the "Create Filters from this Deviation" context menu option on any tab/window shows the modal on all of the open tabs/windows.

This is caused by using the SendMessageToAllTabs helper function in the onClicked event handler for that menu item.

It appears to be a very simple fix: just change this logic to instead use browser.tabs.sendMessage() and pass the tab.id that is sent to the event handler.