search

rthaut / deviantART-Filter

A browser extension that allows you to filter DeviantArt by user, keyword, and/or category.
https://rthaut.github.io/deviantART-Filter/
GNU General Public License v3.0
31 stars 1 forks source link

[v6.1.0] Management page no longer loads in Waterfox browser #141

Closed luckysgb closed 4 years ago

luckysgb commented 4 years ago

The Filter Management page will not load in Waterfox after updating to 6.1.0 (despite the Firefox addon being marked as compatible at the corresponding version) and only shows a blank page. The following error appears in the developer console:

TypeError: Object.fromEntries is not a function (manage.js:77:94675)

It was working in 6.0.0 and older versions. I am using the latest version of Waterfox Classic (2020.05 64-bit)

rthaut commented 4 years ago

Thanks for the detailed report.

MDN claims Object.fromEntries is compatible with Firefox 63+, which was released on October 23, 2018.

It seems odd to me that Waterfox doesn't support it, but I can easily swap that out for something else, likely either Lodash's fromPairs method or this ES6 alternative.

@luckysgb are you able to load an unsigned add-on from a ZIP file, instead of from the Firefox Add-Ons site? If so, would you like me to send an unsigned version of 6.1.1 for you to test before I publish?

rthaut commented 4 years ago

This should be fixed in v6.1.1, which was just released.

If it still doesn't work after updating, feel free to add another comment to this issue (preferred if the error from the console is the same), or open a new issue (preferred if the console error is different now).

luckysgb commented 4 years ago

Sorry, I didn't have a chance to test this until now. I can confirm that this issue is fixed for Waterfox in v6.1.1. Thank you!

However, starting with v6.1.1, the addon shows as incompatible: "This add-on requires a newer version of Firefox (at least version 62.0). You are using Firefox 57.0." I don't think that was the case before. Was that intentional?

(FYI - Waterfox Classic is locked at 57.0 maintain support for pre-WebExtension addons, but stays up-to-date with other Firefox updates, such as security fixes.)

I'd fully understand if you make changes at some point that require a newer version, but as far as I can tell, it still works other than the version check.

rthaut commented 4 years ago

However, starting with v6.1.1, the addon shows as incompatible: "This add-on requires a newer version of Firefox (at least version 62.0). You are using Firefox 57.0." I don't think that was the case before. Was that intentional?

@luckysgb It was indeed intentional, and was missed with the v6.1.0 release. I have made a new issue for tracking the minimum required Firefox version which covers the details, but basically Firefox version 62+ is needed for a feature introduced in DeviantArt Filter v6.1.0. Waterfox evidently has included the change that was introduced in Firefox version 62. If there is a way to specify a minimum Waterfox version (separate from the minimum Firefox version), that would be a good compromise; feel free to continue the discussion in that new issue.