rthornton128 / goncurses

NCurses Library for Go
Other
383 stars 51 forks source link

Build tags misplaced in some files #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. go get on a platform not supported by existing constraints
2. watch as build errors from some files because of inconsistent availability

What version of the product are you using? On what operating system?

hg version 558b54308275  on Darwin

Please provide any additional information below.

Unfortunately, my go editing environment automatically stripped off trailing 
spaces in lines, so the attached diff has a little more diff than strictly 
needed.  Leaving intact anyway.

Original issue reported on code.google.com by syscomet on 5 Oct 2013 at 12:15

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch. I should have it pushed to tip in a couple days. Were you 
able to build the complete library on OSX? If so, I may remove the build tags 
entirely as that was the only reason I added build tags at all.

Original comment by rthornto...@gmail.com on 11 Oct 2013 at 1:47

GoogleCodeExporter commented 9 years ago
I was, yes.  However, it looks as though it used ncurses from MacPorts.  No 
idea if it installs cleanly on a clean install, but frankly I'd just document 
"you need ncurses, confirmed to work with 5.9.20110404 from MacPorts".

% hg pull -u
pulling from https://code.google.com/p/goncurses
searching for changes
no changes found
% go install -v
code.google.com/p/goncurses

I still haven't gotten around to _testing_ it.

go version go1.1.2 darwin/amd64

Xcode 4.6.3

% port installed ncurses
The following ports are currently installed:
  ncurses @5.9_2 (active)

Original comment by syscomet on 11 Oct 2013 at 1:53

GoogleCodeExporter commented 9 years ago
I've removed the build tags entirely for now and see what bugs, if any, crop up 
for Mac users. Some users reported issues with MacPorts but that was a while 
ago and maybe they've been resolved. I'll make the doc changes and update the 
front page.

Original comment by rthornto...@gmail.com on 12 Oct 2013 at 10:22

GoogleCodeExporter commented 9 years ago
Fix pushed to tip and changes made to documentation.

Original comment by rthornto...@gmail.com on 12 Oct 2013 at 10:49