search

rthornton128 / goncurses

NCurses Library for Go
Other
383 stars 51 forks source link

readme update for osx users #31

Closed trotha01 closed 8 years ago

trotha01 commented 8 years ago

Hi, I had some trouble on osx since it seems like ncurses 6.0 does not include the .pc files needed here, such as ncurses.pc, form.pc, etc.

Following the linked blog fixed this issue by creating the missing .pc files and setting the PKG_CONFIG_PATH flag.

rthornton128 commented 8 years ago

Homebrew has never included the package config files, to my knowledge, for some reason. I have always recommended OSX users use the MacPorts version of ncurses for this very reason. You can find this under the KnownIssues section in the wiki.

ncurses 6.0 also includes support for the pkg-config files provided the package maintainer uses the --enable-pc-files option. It is not an ncurses/goncurses issue insomuch as its a homebrew issue. Macports specifically includes this option, as you can see.

You are correct that the readme does need better OSX instructions. However, I would probably reject this patch for an additional reason. I feel that the link should be to official installation instructions found within the project rather than a 3rd-party blog.

I think goncurses would be better served by updating the wiki and readme with better OSX instructions.

Does this solve your issues?

rthornton128 commented 8 years ago

Updated wiki and README in commit 26e08a22e1f1259a724be0e92e1ad762f3224338 for better installation instructions for OSX.

Nullifies pull request.

trotha01 commented 8 years ago

I definitely agree with your 3rd-party blog comment. Thank you for updating the wiki and readme, that definitely helps!