CON-314: Allow returning outstanding loans of Inputs, return loan on calling wait

rticommunity / rticonnextdds-connector-py

RTI Connector for Connext DDS is a lightweight technology that enables DDS data to be accessed with Python.

Other

34 stars 21 forks source link

CON-314: Allow returning outstanding loans of Inputs, return loan on calling wait #179

Closed Alxe closed 2 months ago

Alxe commented 3 months ago

Added new return_samples method to Input class.
Modify wait method to, by default, return the samples.

This requires accessing a new native function, thus requires new native libraries.

alexcamposruiz commented 2 months ago

The PR needs:

A unit test for return_loan() and for wait(return_loan=True/False)
Updating the documentation (input.rst)

Alxe commented 2 months ago

@alexcamposruiz I've applied your changes, please re-review. @rkorte Can you please review the documentation additions in this PR?

Alxe commented 2 months ago

Adding @samuelraeburn as a reviewer on lieu of @alexcamposruiz.

samuelraeburn commented 2 months ago

Change looks good, validation failing because the native libs don't yet have the implementation of return_loan

samuelraeburn commented 2 months ago

Do you also plan to make a similar PR in JS?

Alxe commented 2 months ago

Do you also plan to make a similar PR in JS?

We'll do that eventually for the next JS GAR. This change is targetting a customer patch.

Alxe commented 2 months ago

I've retargeted the PR to the release/connector/1.2.4 branch to avoid breaking the current CI. Once the new native libraries are in place in release/connector/1.2.4, every CI test should be passing.