rticulate / import

An Import Mechanism For R
https://import.rticulate.org
Other
222 stars 14 forks source link

GitHub commit checks have started to fail without discernible reason #60

Closed torfason closed 2 years ago

torfason commented 2 years ago

The commit checks triggered by pull requests such as #55 currently fail even though they passed at the time of the last release, and nothing seems to have changed in the package that should cause such the failure. See for example the results here:

https://github.com/rticulate/import/runs/5777825787?check_suite_focus=true

This is kind of a blocker for a new release of import, but I'm personally not too proficient with GitHub actions, so I would very much appreciate assistance with this.

brshallo commented 2 years ago

Am guessing you have a problem in .github/workflows/pkgdown.yaml. I compared import's setup to my set-up of pkgdown on a recent package I wrote that is working (see file at brshallo/funspotr/.../pkgdown.yaml) and noticed a few subtle differences.

One is that I'm using the v1 rather than the master branch for setting-up pandoc.

imports does:

      - uses: r-lib/actions/setup-pandoc@master

funspotr does:

      - uses: r-lib/actions/setup-pandoc@v1

I checked a more established package and it seems like dplyr/.../pkgdown.yaml also uses v1.

torfason commented 2 years ago

Thanks for the pointers, it turned out to be a bit more than the pandoc version, but comparing to other repos and updating to the current examples in r-lib/actions took care of this. :-)

torfason commented 2 years ago

This now works as intended, all checks are passing on master and dev