Hotfix for #86 - Githubissues

rticulate / import

An Import Mechanism For R

https://import.rticulate.org

Other

222 stars 14 forks source link

Hotfix for #86 #87

Closed J-Moravec closed 7 months ago

J-Moravec commented 7 months ago

This fixes issues of not being able to import classes with dots in their name.

This was actually a bug where sep instead of collapse was used in a vector.

The assumption that the method can't have dot in name remains. Possible fix for that would include looking around for imported generics with dot in name and registering methods for such generics.

In the meantime, there is this hotfix.

torfason commented 7 months ago

Thanks for the fix! I've:

Verified that the new test reproduces the issue
Verified that the updates fixes the issue and the new test
Verified that the updates cause no other tests to fail
Merged this into both dev and main
Updated the version to 1.3.2 and updated the site
Sent a new release to CRAN

Hopefully this will show up an CRAN within a day or two.