search

rtimush / sbt-updates

sbt plugin that can check Maven and Ivy repositories for dependency updates
BSD 3-Clause "New" or "Revised" License
761 stars 55 forks source link

Add support for GitLab authentication #266

Closed ant8e closed 2 years ago

ant8e commented 3 years ago

If the Ivy credential's realm contains the string "gitlab-private-token" a Private-Token HTTP header with the value of the password is used instead of the default basic authentication.

Should fix #241

rtimush commented 3 years ago

Thank you for your contribution! Do I understand it correctly that the gitlab-private-token realm doesn't come from the GitLab itself, but is just a convention?

ant8e commented 3 years ago

Yes, Exactly. It is just here to trigger the usage of the gitlab authentication method. This is a bit of a hack for sure. On the positive side, it allows to use the credentials storage mechanism of SBT. If you feel that this approach is ok, I will add  some documentation  to the PR. On 4 Nov 2021, 23:41 +0100, Roman Timushev @.***>, wrote:

Thank you for your contribution! Do I understand it correctly that the gitlab-private-token realm doesn't come from the GitLab itself, but is just a convention? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

rtimush commented 2 years ago

Hi @ant8e. Sorry for a long delay. This change requires an additional configuration of the builds, which I'd like to avoid. I've been thinking about an alternative way that reads the csrConfiguration setting, and I think I finally figured out a way to do it, while keeping compatibility with the older sbt versions (#276).