rtissera / libchdr

Standalone library for reading MAME's CHDv1-v5 formats.
BSD 3-Clause "New" or "Revised" License
96 stars 38 forks source link

Suggestion: Add ZStandard Codec Support #35

Closed kcgen closed 7 months ago

kcgen commented 3 years ago

ZStandard Codec Support

Sanaki commented 3 years ago

This repo is a library for reading MAME's chd format. It doesn't have any influence over the chd format itself. For that, you'll need to open issues on https://github.com/mamedev/mame/.

kcgen commented 3 years ago

Thanks @Sanaki! (Closing)

Sanaki commented 3 years ago

I'd imagine this applies to #34 and #36 as well. Feel free to correct me if I'm wrong though. EDIT: I read over them again, not actually sure it does.

kcgen commented 3 years ago

(Ref: https://github.com/mamedev/mame/issues/7386)

InquisitiveCoder commented 9 months ago

Can this be revisited? MAME just added zstd support to chdman in this PR: https://github.com/mamedev/mame/pull/11827

rtissera commented 9 months ago

Owww that’s a HUGE win ! Yes definitely !

Le lun. 11 déc. 2023 à 20:41, InquisitiveCoder @.***> a écrit :

Can this be revisited? MAME just added zstd support to chdman in this PR: mamedev/mame#11827 https://github.com/mamedev/mame/pull/11827

— Reply to this email directly, view it on GitHub https://github.com/rtissera/libchdr/issues/35#issuecomment-1850765878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW4WBKIWJKXTPDG5ZR5MJ3YI5OYNAVCNFSM4S5ER6D2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGA3TMNJYG44A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

malvarenga123 commented 8 months ago

Should this issue be reopened until it's implemented?

rtissera commented 8 months ago

Yes since MAME chaman now does it.

Sanaki commented 7 months ago

I believe this was resolved in #106 and can be closed again.

rtissera commented 7 months ago

Yes, indeed, MAME team bit the bullet and implemented in chdman 0.262 It needs to be manually specified at compression time. Closing.