rtissera / libchdr

Standalone library for reading MAME's CHDv1-v5 formats.
BSD 3-Clause "New" or "Revised" License
98 stars 42 forks source link

Compilation error after PR #93 #98

Closed DrUm78 closed 1 year ago

DrUm78 commented 1 year ago

Hello,

PR #93 introduced a compilation error:

pico/cd/libchdr/src/libchdr_flac.c:16:10: fatal error: dr_flac.h: No such file or directory
   16 | #include <dr_flac.h>
      |          ^~~~~~~~~~~
compilation terminated.
make: *** [Makefile:405: pico/cd/libchdr/src/libchdr_flac.o] Error 1

Indeed, dr_flac.h is in deps/dr_libs/ but the include in src/libchdr_flac.c is:

#include <dr_flac.h>

Of course I can fix the include path myself, but just wanted to let you know.

rtissera commented 1 year ago

Thanks I merged a bunch of commits and fixes from @scribam recently probably linked to.

scribam commented 1 year ago

@DrUm78 do you use a custom Makefile or do you have the error with cmake? how can I reproduce your compilation error?

DrUm78 commented 1 year ago

@scribam I use PicoDrive Makefile here: https://github.com/irixxxx/picodrive/blob/3a77090514c3ba3c1a0286a046bc9fe323e07f27/Makefile#L319 You can reproduce it by compiling this repo under x86_64 for instance after a git submodule update --init.

Same issue when compiling libchdr within PCSX (https://github.com/notaz/pcsx_rearmed) too.

scribam commented 1 year ago

I made a pull request to revert the offending commit and keep the compatibility with current Makefiles

rtissera commented 1 year ago

Revert merged please confirm issue is fixed.

DrUm78 commented 1 year ago

All good now, thanks guys. 👍