rtivital / omatsuri

PWA with 12 open source frontend focused tools
https://omatsuri.app
MIT License
2.6k stars 202 forks source link

yarn/npm #2

Closed mzastue closed 4 years ago

mzastue commented 4 years ago

Hi, first really nice code structure and design.

One question about contributing section:

# Install dependencies
yarn

# Start application, browser will open automatically
npm start

Install with yarn and run with npm ? :) I guess run and install with npm/yarn but sticking to only one tool. Or even following package structure it should be yarn because of yarn.lock file, right? :D

rtivital commented 4 years ago

Hi, there is no difference how to run scripts from package.json with npm or yarn – it has no connections to dependencies and if you have yarn install then you have npm too.

mzastue commented 4 years ago

Yea right, but if you install with npm then you will get package-lock.json in return ;)

rtivital commented 4 years ago

Yes, that's why it says that you should install it with yarn. Running scripts with npm or yarn does not produce lock files