search

rtivital / omatsuri

PWA with 12 open source frontend focused tools
https://omatsuri.app
MIT License
2.54k stars 201 forks source link

Fixed issue with removing fake-data-generator field #24

Closed sodiqlawal closed 2 years ago

rtivital commented 2 years ago

Thanks!

sodiqlawal commented 2 years ago

My Pleasure!

On Fri, Feb 25, 2022 at 7:51 AM Vitaly Rtishchev @.***> wrote:

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/rtivital/omatsuri/pull/24#issuecomment-1050575566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4YBATAKPM3CEWEC25OGIDU44RIBANCNFSM5PJGKCDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

CookedIdeas commented 8 months ago

Hello there ! First I must thank you for sharing your work and this useful tools !

I noticed an issue in the online version of omatsuri with the remove field feature : on click on "remove", the first field of the list is removed, not the selected one as expected.

I forked the original repo to start debugging it. But when running the app in localhost:8262, the remove field functionality works perfectly. Works also in production environment after running npm run serve.

So here's a message to notify that the online version is not up-to-date with this feature ;)