search

rtlabs-com / p-net

PROFINET device stack for embedded devices
http://www.rt-labs.com
Other
480 stars 194 forks source link

Correct shutdown sequence #315

Closed giuseppe-avon closed 3 years ago

giuseppe-avon commented 3 years ago

I am using the library for my slave device. I am experiencing troubles when I run two consecutive (non-parallel) runs: while the first goes without problems, the second one never receives the State Indication change and causes a "00006001 RPC_Request_Blocked" on the Codesys Control for Linux instance. I am issuing the pnet_ar_abort command to then wait for the Abort State Indication, after that I just stop calling the pnet_handle_periodic(). What I don't really understand is if this is the right way to handle the slave disconnection, leaving things clean for the next instance to be executed. Thanks.

giuseppe-avon commented 3 years ago

Is there something which may be dual to the pnet_init, in order to close the AF_PACKET socket left open? I've also analyzed traffic with wireshark and it seems that p-net, on the n-th consecutive run after the first stops responding to the connect request from the master.

giuseppe-avon commented 3 years ago

FWIW apparently solved by just adding setsockopt(id, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one));

just before the ret = bind (id, (struct sockaddr *)&local, sizeof (local));

in function int pnal_udp_open (pnal_ipaddr_t addr, pnal_ipport_t port)

Seems like stray sockets remain when closing happens by means of interruption. However, this pinpoints to a misbehaving close/cleanup stage.

pyhys commented 3 years ago

Thanks for your update! We need look into this.

Best regards Jonas