rtoma / logspout-redis-logstash

Logspout adapter for writing Docker container logs to Redis in Logstash jsonevent layout
Apache License 2.0
33 stars 28 forks source link

redis retry can cause exceeding 1 second timeout. #10

Open drewrobb opened 8 years ago

drewrobb commented 8 years ago

With the changes introduced in https://github.com/rtoma/logspout-redis-logstash/commit/b96fbb63fa275395647ce01601f80d645227e591 we are seeing in production it is still possible for a pump send to timeout. The retry after a first error opens a connection again and tries to push again. If the first error is because of a timeout, there might not be enough time remaining out of the 1 second budget given by logspout. Fix ideas I have are introducing a timeout external from the redis client, simply removing the retry code, or fixing the 1 second timeout budget + closing the pump permanently after a single timeout upstream (I've opened an issue for this).

rtoma commented 8 years ago

Thank you for your comment and the upstream issue.