search

rtomayko / git-sh

A customized bash environment suitable for git work.
GNU General Public License v2.0
737 stars 83 forks source link

Adding support for .bash_profile #31

Open taupecat opened 11 years ago

taupecat commented 11 years ago

Most OS X systems have .bash_profile files, not .bashrc. This pull request adds .bash_profile sourcing.

nikreiman commented 11 years ago

One of my many OSX pet peeves. I think most unix junkies end up eventually symlinking ~/.bashrc to ~/.bash_profile after getting burned by this. But anyways, nice fix! However I think it'd be nicer if this fix only modified one of the two files (ie, if/elif), otherwise the file will be sourced twice if the user has both files (not uncommon in my experience).

taupecat commented 11 years ago

Hadn't thought of symlinking. Seems obvious in retrospect. At first, I just put a "source ~/.bash_profile" in an otherwise empty .bashrc file before deciding that was too clunky and it was just as easy to change the build script.

I'll try adding the logic at some point.

Something else that was bugging me working with git-sh yesterday was its lack of support for git-flow, an add-on that I think is fairly popular (at least, we use it heavily where I work). I'll see what's involved in adding that as well.

vlad2 commented 7 years ago

Hello,

I've merged the 'git flow' alias into my fork at https://github.com/vlad2/git-sh.

I didn't merge the rest of the .bash_profile changes, as they overwrite the .bashrc usage, which would ruin the fun of Linux users, at least in the current state of this pull request. I wanted to merge the entire pull request at first, I thought it would make it work on both Linux/OSX.