rtomayko / posix-spawn

Ruby process spawning library
Other
519 stars 52 forks source link

Fix three real bugs and a pile of broken unit tests #58

Closed piki closed 10 years ago

piki commented 10 years ago

Added sanity checks for invalid :chdir (needed a new test) and fd => :close (fixed an existing test) options.

Stop ignoring SIGPIPE. Fixes two hung tests on OS X. Without this fix, yes runs forever instead of dying with SIGPIPE.

Protect dup'd fds from being closed on exec, in both pspawn and fspawn.

Removed a bashisms from 7 unit tests. They now pass with both dash (the default on modern Debian) and bash (still the default on OS X).

I have tested on:

parkr commented 10 years ago

This is splendid! :heart:

They run on my machine, too. Thanks a lot for the fixes, and for taking the time to look into this. You rock! :metal:

tmm1 commented 10 years ago

Nice.

piki commented 10 years ago

@tmm1 :shipit:?