Closed piki closed 10 years ago
Added sanity checks for invalid :chdir (needed a new test) and fd => :close (fixed an existing test) options.
:chdir
fd => :close
Stop ignoring SIGPIPE. Fixes two hung tests on OS X. Without this fix, yes runs forever instead of dying with SIGPIPE.
yes
Protect dup'd fds from being closed on exec, in both pspawn and fspawn.
pspawn
fspawn
Removed a bashisms from 7 unit tests. They now pass with both dash (the default on modern Debian) and bash (still the default on OS X).
dash
bash
I have tested on:
/bin/sh
This is splendid! :heart:
They run on my machine, too. Thanks a lot for the fixes, and for taking the time to look into this. You rock! :metal:
Nice.
@tmm1 :shipit:?
Added sanity checks for invalid
:chdir
(needed a new test) andfd => :close
(fixed an existing test) options.Stop ignoring SIGPIPE. Fixes two hung tests on OS X. Without this fix,
yes
runs forever instead of dying with SIGPIPE.Protect dup'd fds from being closed on exec, in both
pspawn
andfspawn
.Removed a bashisms from 7 unit tests. They now pass with both
dash
(the default on modern Debian) andbash
(still the default on OS X).I have tested on:
/bin/sh
symlinked to bothdash
andbash