search

rtomayko / posix-spawn

Ruby process spawning library
Other
519 stars 52 forks source link

tests: switch to minitest 5 #65

Closed ktdreyer closed 10 years ago

ktdreyer commented 10 years ago

This pull request switches from Test::Unit to Minitest 5's syntax. It also refactors the duplicated test requires lines into test_helper.

piki commented 10 years ago

No strong opinion here. Why is this change needed?

ktdreyer commented 10 years ago

As of Minitest 5, the Test::Unit shim has broken some compatibility with Test::Unit::TestCase in some scenarios. assert_raise -> assert_raises is the big relevant change in posix-spawn's case.

Minitest has superceded Test::Unit in most cases, and this change is about keeping up with the latest conventions in test frameworks. From the stdlib docs:

If you are writing new test code, please use MiniTest instead of Test::Unit.

Test::Unit has been left in the standard library to support legacy test suites.
piki commented 10 years ago

:+1: for keeping current.

ktdreyer commented 9 years ago

Thanks for merging!