Fix errors in 1.8.7 - Githubissues

rtomayko / posix-spawn

Ruby process spawning library

Other

520 stars 52 forks source link

Fix errors in 1.8.7 #66

Closed takahashim closed 9 years ago

takahashim commented 9 years ago

cf. #62

Kernel::exec do not allow options in 1.8, so ignore them
splat operator allowed with only one arguments
close_on_exec= is not supported, so ignore them

rtomayko commented 9 years ago

LGTM assuming there are no issues w/ in place modification. Moving to + would be preferable I think. Building the arrays up on lines separate from the invocation / splat may also improve readability.

takahashim commented 9 years ago

Thanks for your comments. I fixed them.

rtomayko commented 9 years ago

Perfect, thanks!

takahashim commented 9 years ago

Thanks! :smiley: