search

rtomayko / rack-cache

Real HTTP Caching for Ruby Web Apps
http://rtomayko.github.io/rack-cache/
Other
822 stars 124 forks source link

Remove thread id from cache filename. #106

Closed basex closed 9 years ago

basex commented 9 years ago

Related with Issue: https://github.com/rtomayko/rack-cache/issues/98

rtomayko commented 9 years ago

It looks like the current behavior is correct. I left a comment with more detail in https://github.com/rtomayko/rack-cache/issues/98#issuecomment-69785561. Are you seeing cache misses? I'm trying to figure out how this thread id could influence the final location of the cache file.

basex commented 9 years ago

It makes sense on the temporary file as a protection but I don't see any reason to be on the final filename.

I have been in production for a while but I haven't been checking the logs that often to see if there was a problem.

rtomayko commented 9 years ago

Closing due to https://github.com/rtomayko/rack-cache/issues/98#issuecomment-69785561. Thanks!