search

rtomayko / rack-cache

Real HTTP Caching for Ruby Web Apps
http://rtomayko.github.io/rack-cache/
Other
822 stars 124 forks source link

bump ruby requirement #150

Closed grosser closed 6 years ago

grosser commented 6 years ago

travis fails because of a ruby 1.9 bug in minitest-line https://travis-ci.org/rtomayko/rack-cache/jobs/346354873

... time to drop 1.9 ? (old versions can still be used)

@rtomayko @amatriain @rmm5t

rmm5t commented 6 years ago

Not sure I deserve to be included here, but as far as I'm concerned, I've started dropping official 1.9 (and 2.0 and 2.1) support in all my open source projects.

Ruby 2.2 is about to reach end-of-life soon too

rtomayko commented 6 years ago

:+1: to dropping. My only question would be: what's the expected semver impact for a change like this? Feels terrible to require a major bump but also could break existing environments without it.

grosser commented 6 years ago

does not break anyone since bundler picks the correct version ... I'd minor bump so we can release patch releases for the old version

grosser commented 6 years ago

actually don't even need to release this ... we can do that whenever the next feature comes in