search

rtomayko / tilt

Generic interface to multiple Ruby template engines
http://github.com/rtomayko/tilt
Other
1.95k stars 226 forks source link

Support Commonmarker v1 api #396

Closed unasuke closed 8 months ago

unasuke commented 8 months ago

What

The Commonmarker gem released v1 incluging breaking api changes. https://github.com/gjtorikian/commonmarker/releases/tag/v1.0.0

These changes supports the new commonmarker's api.

To support commonmaker's breaking api changes, tilt gem will release new version including incompatible api change also. For notice to tilt gem user, is it better to check commonmarker gem's version?

jeremyevans commented 8 months ago

Thank you very much for the patch. However, the changes to tilt must be backwards compatible and continue to work with the older commonmarker API. This is especially true since commonmarker >= 1:

In tilt/commonmarker, you'll need to check the commonmarker version after requiring it, and make the appropriate changes so it works with both versions. Do you think you'd be able to make those changes?

unasuke commented 8 months ago

In tilt/commonmarker, you'll need to check the commonmarker version after requiring it, and make the appropriate changes so it works with both versions. Do you think you'd be able to make those changes?

I'll write a patch that works for both versions of commonmaker. But it's hard to write a test code (prepare test environment) I think.

jeremyevans commented 8 months ago

In tilt/commonmarker, you'll need to check the commonmarker version after requiring it, and make the appropriate changes so it works with both versions. Do you think you'd be able to make those changes?

I'll write a patch that works for both versions of commonmaker. But it's hard to write a test code (prepare test environment) I think.

I just noticed, but you filed this against the rtomayko repository, which is no longer used. You need to submit the pull request to https://github.com/jeremyevans/tilt. That has a CI that runs for pull requests. CI should be able to check if it works with both versions of commonmarker. Just remove the version restriction for commonmarker in .ci.gemfile in the pull request.

unasuke commented 8 months ago

You need to submit the pull request to https://github.com/jeremyevans/tilt.

Oops. I forgot to check the repository url on rubygems.org. Thanks!