search

rtoy / maxima

A Clone of Maxima's repo
Other
0 stars 0 forks source link

maxima.el triggers a warning about deprecated positional arguments to define-minor-mode #3673

Open rtoy opened 2 months ago

rtoy commented 2 months ago

Imported from SourceForge on 2024-07-08 11:08:47 Created by vinc17 on 2024-06-26 13:50:33 Original: https://sourceforge.net/p/maxima/bugs/4324

maxima.el triggers the following warning in Debian/unstable (thus from Maxima 5.47.0) at install time:

Install maxima-emacs for emacs
install/maxima: Handling install for emacsen flavor emacs
maxima.el: Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode'
rtoy commented 2 months ago

Imported from SourceForge on 2024-07-08 11:08:48 Created by l_butler on 2024-06-27 13:41:57 Original: https://sourceforge.net/p/maxima/bugs/4324/#0afa

Byte-compiling maxima.el shows there are a lot of warnings along similar lines. The one reported here is on line 3585.

maxima.el:246:11: Warning: defgroup for ‘maxima’ fails to specify containing
    group
maxima.el:313:2: Warning: custom-declare-variable `maxima-indent-style'
    docstring has wrong usage of unescaped single quotes (use \= or different
    quoting)
maxima.el:322:2: Warning: custom-declare-variable `maxima-return-style'
    docstring has wrong usage of unescaped single quotes (use \= or different
    quoting)

In maxima-strip-string-beginning:
maxima.el:533:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-strip-string-end:
maxima.el:550:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-remove-whitespace-from-ends:
maxima.el:587:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-remove-whitespace-from-beg:
maxima.el:609:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-remove-whitespace-from-end:
maxima.el:628:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-back-over-function-name:
maxima.el:1418:2: Warning: docstring has wrong usage of unescaped single
    quotes (use \= or different quoting)

In maxima-get-help:
maxima.el:1837:13: Warning: assignment to free variable ‘name’
maxima.el:1838:33: Warning: reference to free variable ‘name’

In maxima-apropos:
maxima.el:1896:10: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-help-variation:
maxima.el:2012:8: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer
maxima.el:2023:8: Warning: ‘mapcar’ called for effect; use ‘mapc’ or ‘dolist’
    instead

In maxima-check-parens:
maxima.el:2264:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-mode:
maxima.el:2568:2: Warning: docstring has wrong usage of unescaped single
    quotes (use \= or different quoting)
maxima.el:2642:4: Warning: ‘easy-menu-add’ is an obsolete function (as of
    28.1); this was always a no-op in Emacs and can be safely removed.

In inferior-maxima-remove-double-input-prompt:
maxima.el:2702:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-start:
maxima.el:2779:14: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer
maxima.el:2789:8: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-get-command:
maxima.el:2858:6: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-last-output:
maxima.el:2929:4: Warning: Use ‘with-current-buffer’ rather than
    save-excursion+set-buffer

In maxima-send-completed-region:
maxima.el:3085:2: Warning: docstring wider than 80 characters

In maxima-minibuffer-on-determined-region:
maxima.el:3530:2: Warning: docstring wider than 80 characters
maxima.el:3585:20: Warning: Use keywords rather than deprecated positional
    arguments to `define-minor-mode'

In end of data:
maxima.el:2644:8: Warning: the function ‘add-local-hook’ is not known to be
    defined.
maxima.el:2362:10: Warning: the function ‘delete-extent’ is not known to be
    defined.
maxima.el:2350:14: Warning: the function ‘set-extent-property’ is not known to
    be defined.
maxima.el:2347:20: Warning: the function ‘make-extent’ is not known to be
    defined.
maxima.el:2174:6: Warning: the function ‘comint-dynamic-simple-complete’ is
    not known to be defined.
maxima.el:2158:14: Warning: the function ‘mouse-choose-completion’ is not
    known to be defined.
maxima.el:2023:25: Warning: the function ‘maxima-help-insert-line’ is not
    known to be defined.
maxima.el:514:10: Warning: the function ‘make-local-hook’ is not known to be
    defined.

Emacs info:

GNU Emacs 29.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0)
 of 2024-05-15, modified by Debian
rtoy commented 2 months ago

Imported from SourceForge on 2024-07-08 11:08:51 Created by l_butler on 2024-06-27 13:42:44 Original: https://sourceforge.net/p/maxima/bugs/4324/#6125