olivierobert
commented
8 months ago I have now complete the review of the changes made for the issues 🏁
It took me more time as you merged the PRs prior to my review (i.e., I expected to have some time to review the changes before you merged them). Another unexpected part of the code review is that you did not respond to any of the issue or comments I made. As a result, I could not assess how you would collaborate with others 😓
In any case, it is is now time to wrap up the stage of the technical assessment. I will coordinate with our talent team to provide with our feedback shortly. Thank you for your efforts 🙏
Hello Ratapan 👋 , thank you for your effort on the code submission. I am Olivier at Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.
We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇
In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘