rtp-ch / rtp_imgquery

Responsive and fluid image techniques for TYPO3
Other
28 stars 0 forks source link

[FEATURE] Show Retina optimized images #4

Closed mrimann closed 11 years ago

mrimann commented 11 years ago

This feature must be enabled by adding the second static template to the configuration. After that, the device pixel ratios of 1.5 and 2.0 are configured via TS - but can be overridden within the CE.

On the client side, the whole thing triggers only if the device pixel ratio is higher than 1.0 higher or equal than the lowest of the defined pixel ratios.

If possible, the client selects a better image, fitting it's high-res screen and displays that.

mrimann commented 11 years ago

Needless to say, this needs some love and TESTING - it was hacked together just within a few hours on the couch, you know...? :-)

simontuck commented 11 years ago

I have done some heavy refactoring and implemented your feature (without pulling your commits). Can you test the current release and see if it's working for you?

mrimann commented 11 years ago

We'll give it a try and provide feedback!

mrimann commented 11 years ago

Hi Simon With todays version on a 6.0.x installation, we're running into an Exception/Break from Xdebug:

Fatal error: Maximum function nesting level of '999' reached, aborting!

We've also tried that with a higher limit of 9999 - but it ends up with the same issue. What we found out during the test was that the error only ocurred, as long as there was at least one break-point configured (didn't matter whether this was via TS or from within the content element). As soon as we removed all break-points from the config, the page again was shown (but of course with the default images being shown).

I've not yet found time to dig into this issue deeper to see what could be going wrong here.

Cheers, Mario

mrimann commented 11 years ago

Hi Simon

David has dug deeper and filed two separate issues: #7 and #8

Besides thouse two issues, the new version seems to work fine and I'm for closing this pull request here. What do you think?

Cheers, Mario

simontuck commented 11 years ago

Thanks for taking the time to look into this. I agree: close the pull request and I'll have a look at issues #7 and #8. Cheers, Simon