rtr7 / router7

router7 is a small home internet router completely written in Go. It is implemented as a gokrazy appliance.
https://router7.org
Apache License 2.0
2.69k stars 110 forks source link

Failing build #54

Closed CodeZombieCH closed 4 years ago

CodeZombieCH commented 4 years ago

I think the latest additions to gokrazy broke the build of router7.

I tried to reproduce the build failure in a docker container:

me@host: docker run --rm -t -i golang:1.14-buster bash
root@9d2557ae7b13:/go# go get -u github.com/gokrazy/tools/cmd/gokr-packer github.com/rtr7/tools/cmd/...
root@9d2557ae7b13:/go# go get -u -d github.com/rtr7/router7
root@9d2557ae7b13:/go# mkdir /tmp/recovery
root@9d2557ae7b13:/go# GOARCH=amd64 gokr-packer \
> -hostname=router7 \
> -overwrite_boot=/tmp/recovery/boot.img \
> -overwrite_mbr=/tmp/recovery/mbr.img \
> -overwrite_root=/tmp/recovery/root.img \
> -kernel_package=github.com/rtr7/kernel \
> -firmware_package=github.com/rtr7/kernel \
> -gokrazy_pkgs=github.com/gokrazy/gokrazy/cmd/ntp \
> -serial_console=ttyS0,115200n8 \
> github.com/rtr7/router7/cmd/...
2020/07/01 20:29:08 packer.go:353: building [github.com/rtr7/router7/cmd/...]
2020/07/01 20:29:08 gotool.go:77: getting incomplete packages [github.com/gokrazy/gokrazy/cmd/ntp github.com/rtr7/router7/cmd/backupd github.com/rtr7/router7/cmd/captured github.com/rtr7/router7/cmd/dhcp4 github.com/rtr7/router7/cmd/dhcp4d github.com/rtr7/router7/cmd/dhcp6 github.com/rtr7/router7/cmd/diagd github.com/rtr7/router7/cmd/dnsd github.com/rtr7/router7/cmd/dyndns github.com/rtr7/router7/cmd/netconfigd github.com/rtr7/router7/cmd/radvd github.com/gokrazy/gokrazy github.com/rtr7/kernel]
2020/07/01 20:31:48 write.go:149: writing boot file system
can't load package: package github.com/gokrazy/rpi-eeprom: cannot find package "github.com/gokrazy/rpi-eeprom" in any of:
    /usr/local/go/src/github.com/gokrazy/rpi-eeprom (from $GOROOT)
    /go/src/github.com/gokrazy/rpi-eeprom (from $GOPATH)
2020/07/01 20:31:48 packer.go:822: [go list -f {{ .Dir }} github.com/gokrazy/rpi-eeprom]: exit status 1
stapelberg commented 4 years ago

This failure will most likely vanish once:

  1. you run gokr-packer in a directory that contains a go.mod file (e.g. the router7 directory)
  2. or: explicitly go get github.com/gokrazy/rpi-eeprom
  3. or: explicitly set -eeprom_package= (which we should probably set in our makefile)
CodeZombieCH commented 4 years ago

Sorry for my late reply. I fixed it by setting the -eeprom_package= flag. Just checked the documentation, :+1: for updating the documentation as well.