search

rtreffer / LocalGSMLocationProvider

Local opencellid based location provider backend for UnifiedNlp
Apache License 2.0
43 stars 10 forks source link

Please fix v0.0.1.2 tag #2

Closed aelmahmoudy closed 10 years ago

aelmahmoudy commented 10 years ago

Hello,

The v0.0.1.2 tag should point to e32ea96f81fb01076bafad30f1513d205db88e4f commit (where AndroidManifest.xml was updated), not the one before it. Thanks.

rtreffer commented 10 years ago

Well, the tag point to the revision that was tagged and uploaded as a release. Would it be OK if I tag/release this as 0.0.1.3?

aelmahmoudy commented 10 years ago

On Tue, Mar 18, 2014 at 05:47:06AM -0700, Rene Treffer wrote:

Well, the tag point to the revision that was tagged and uploaded as a release. Would it be OK if I tag/release this as 0.0.1.3? ---end quoted text---

I don't think that would be correct. The point is to have the tag corresponding to the version in AndroidManifest.

That would help us to auto-build new releases for FDroid.

‎أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

rtreffer commented 10 years ago

The problem is that I don't want to change the content of a tag. That's not what tags are for - they are one moment in time and should never change (actually). Even if that means it will tag a broken version (which is what happened, but I've also uploaded a binary and source + binary should match).

I'd thus create a new version + tag that is correct. I would then pull 0.0.1.2 as "historical". This would most likely happen in ~6-8 hours.

Is there anything else you'd need / prefer for f-droid inclusion?

aelmahmoudy commented 10 years ago

Thanks. That's just fine. For F-Droid: I hope for future releases though you would keep using consistent tag naming convention (like v that you've already used).

Thanks again...

‎أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

rtreffer commented 10 years ago

Hi,

I've just pushed v0.0.1.3. It has the same name in the AndroidManifest and uses versionCode=13. I hope this is what you need. Otherwise just reopen (or open a new issue if it's unrelated)

Please note that this repo depends on the UnifiedNlp and does not work as a standalone app (it does no harm, but it won't do anything useful).

aelmahmoudy commented 10 years ago

Thanks.

It seems though that the tag is ahead of master branch ? Maybe you didn't push the master branch ?

rtreffer commented 10 years ago

True story :-( pushed