search

rtsao / csjs

:sparkles: Modular, scoped CSS with ES6
MIT License
576 stars 32 forks source link

Added unscoped mode #53

Closed neurosnap closed 7 years ago

neurosnap commented 7 years ago

So this is my attempt at a no-scope option. It is very similar to #31 but I tried to remove any unnecessary code for the no-scope options.

As you can see I also duplicated all the tests for the no-scope option.

I also made the csjsTemplate parameter an object so it can be a little easier to configure down the road.

Let me know what you think. Thanks.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 49998743fe73b967df0430ff05fa0fbcc7960546 on neurosnap:noscope into 5df5123e7a99177740dc471d9753977e0b91cffe on rtsao:master.

avesus commented 7 years ago

Gorgeous!

On Friday, August 12, 2016, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/7434261

Coverage remained the same at 100.0% when pulling 4999874 https://github.com/rtsao/csjs/commit/49998743fe73b967df0430ff05fa0fbcc7960546 on neurosnap:noscope into 5df5123 https://github.com/rtsao/csjs/commit/5df5123e7a99177740dc471d9753977e0b91cffe on rtsao:master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rtsao/csjs/pull/53#issuecomment-239604873, or mute the thread https://github.com/notifications/unsubscribe-auth/AD9MI9tTkLmPYuCghaiPzBQftkEn6i3Rks5qfWAtgaJpZM4Jjne9 .

Best Regards, Ivan Borisenko

rtsao commented 7 years ago

Awesome work! This looks good. 😄

avesus commented 7 years ago

Ryan @rtsao when to expect publishing this changes on NPM? I want depend on it in production.