search

rtts / ialauncher

Play all of the Internet Archive’s MS-DOS games offline!
GNU General Public License v3.0
78 stars 6 forks source link

Don't download games to the installation directory #11

Closed JaapJoris closed 3 years ago

JaapJoris commented 3 years ago

If you install IA Launcher as root on Linux, or as administrator on macOS or Windows, it will not be able to download games because the installation directory is not writable by regular users. The interface will hang at the download stage (see also issue #9).

I'm not sure what the best cross-platform solution is. The games/ directory currently contains metadata and title screens, which are included in the Python package as non-code-files, which is the correct way to do it for read-only files.

A possible user-friendly solution could be to ask the user where they would like to store their downloaded games, and then use that location for downloading files. A nice benefit would be that this location would contain only the games that the user has started at least once.

Until this is solved, please don't install IA Launcher as root, or you'll be forced to run it as root to be able to use it.

JaapJoris commented 3 years ago

Just don't install IA Launcher as root and everything will be fine :)