search

rtxm / rust-nrf24l01

A pure Rust user space driver for NRF24L01(+) transceivers on Linux.
15 stars 29 forks source link

Bring up to date with upstream #1

Closed barafael closed 3 years ago

barafael commented 3 years ago

Since this can be merged without conflicts, I decided to bring this up. Auto-ack is supported upstream FWIW. Willing to test this!

rtxm commented 3 years ago

Technically, here is "upstream", this is the original :wink:

We already support auto-ack, that's the default, so I don't understand the purpose of this PR.

I'm glad my humble code was useful to the embedded team, but their aim is different (they try to offer comprehensive low-level support portable to many micro-controller), the code diverged too much since the fork.

My goal is just to provide an easy, high level API for Linux. Maybe, I should re-build this API upon theirs to avoid duplication of effort.

barafael commented 3 years ago

Maybe the purpose was just to bring up the topic for your consideration :D

rtxm commented 3 years ago

Closing this now, considering it would be probably better to rewrite this API upon https://github.com/astro/embedded-nrf24l01 rather than merging back.