JUnit bundled into libary

rtyley / spongycastle

Spongy Castle - a repackage of Bouncy Castle for Android (which ships a crippled version of BC)

https://rtyley.github.io/spongycastle/

MIT License

683 stars 141 forks source link

JUnit bundled into libary #39

Open rmeissner opened 6 years ago

rmeissner commented 6 years ago

When we were inspecting our runtime dependencies we realized that spongycastle bundles JUnit. Is this really necessary?

debugCompileClasspath - Resolved configuration for compilation for variant: debug
.
.
.
+--- com.madgag.spongycastle:prov:1.58.0.0
|    +--- com.madgag.spongycastle:core:1.58.0.0
|    \--- junit:junit:4.12
|         \--- org.hamcrest:hamcrest-core:1.3

rmeissner commented 6 years ago

This can be fixed my merging #38

jbuhacoff commented 5 years ago

You can build your own BC/SC jars from the current version (1.62), see my comment on issue #34.