ruabmbua / hidapi-rs

Rust bindings for the hidapi C library
MIT License
172 stars 81 forks source link

Consider dropping the failure depedency #42

Closed lnicola closed 5 years ago

lnicola commented 5 years ago

The failure dependency doesn't do much here, and is a bit heavy because of the transitive dependency to syn. Removing it reduces the release build time from 13 to 4 seconds.

failure also brings some interoperability problems with crates that don't use it.

I can submit a PR to replace it with a hand-rolled implementation, but it's technically a breaking change. Do you have anything against it? And if we introduce a breaking change now, can we also update to the 2018 edition and start using dyn Trait to get rid of some compiler warnings?