ruanxiang / mr_saliency

a python implementation of manifold ranking saliency
GNU General Public License v2.0
49 stars 12 forks source link

Updated for OpenCV 3 and skimage > 0.17 and python 3 #2

Closed xkunglu closed 6 years ago

xkunglu commented 6 years ago

Changed skimage.data.lena() to .camera() as lena was removed due to copyright https://github.com/scipy/scipy/pull/5162

added cv2 version check to handle name space changes.

changed <> for the equivalent !=, former not working in python 3.6

xkunglu commented 6 years ago

hey ruanxiang,

As you saw i branched it to add a setup. I tried to change the least amount of things, If you want to edit the setup file to correct credits, or whatever, please do. If you want me to do a pull request in the new state, let me know. I am just trying different ways to aid in image segmentation and i find it easier to just run a python setup or pip install . on any code that i test.

thanks for the depot.

On Tue, Apr 3, 2018 at 6:13 PM, Xiang Ruan notifications@github.com wrote:

Merged #2 https://github.com/ruanxiang/mr_saliency/pull/2.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ruanxiang/mr_saliency/pull/2#event-1555410579, or mute the thread https://github.com/notifications/unsubscribe-auth/Ajrkig2kUa9oJ_HXnJKDvCOTrgiX-rpLks5tlB5IgaJpZM4TFmlu .

ruanxiang commented 6 years ago

Hello, xkunglu

Thank you so much for contributing MR python.

I am definitely a lazy guy to maintain my code, so appreciate your work! Yes, please send me a pull request in the new state.

Thank you again!

Best regards,

xkunglu commented 6 years ago

Hey Xiang, I tried to do a pull request, i dont know if it took hold, if not ill try again. cheers xk

On Fri, Apr 6, 2018 at 7:19 AM, Xiang Ruan notifications@github.com wrote:

Hello, xkunglu

Thank you so much for contributing MR python.

I am definitely a lazy guy to maintain my code, so appreciate your work! Yes, please send me a pull request in the new state.

Thank you again!

Best regards,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ruanxiang/mr_saliency/pull/2#issuecomment-379267956, or mute the thread https://github.com/notifications/unsubscribe-auth/Ajrkiukvip9EoKgdnLlk7dfIA9sA4sQOks5tl3mNgaJpZM4TFmlu .

ruanxiang commented 6 years ago

Hi, xkunglu

Actually I am waiting for your pull request, but didn't receive any notification from GitHub. Have I missed something?

Could you please try again?

xkunglu commented 6 years ago

sorry Xiang, Im having github issues. Ill read up on whats my problem then do a new pull request.

On Sat, Apr 14, 2018 at 5:38 AM, Xiang Ruan notifications@github.com wrote:

Hi, xkunglu

Actually I am waiting for your pull request, but didn't receive any notification from GitHub. Have I missed something?

Could you please try again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ruanxiang/mr_saliency/pull/2#issuecomment-381326327, or mute the thread https://github.com/notifications/unsubscribe-auth/AjrkihQ4ZhAxOPNOoL5N7ccnynKtk0XVks5toe3BgaJpZM4TFmlu .

xkunglu commented 6 years ago

never mind, it seems the pull request did work. Sorry again, Im new to github. Also I dont read email often, as you see. thank you! I will fix a few other things in there - like dependencies, etc, then pull again. But I dont look at this project often.

On Thu, Apr 19, 2018 at 11:14 AM, xk unglu xkunglu@gmail.com wrote:

sorry Xiang, Im having github issues. Ill read up on whats my problem then do a new pull request.

On Sat, Apr 14, 2018 at 5:38 AM, Xiang Ruan notifications@github.com wrote:

Hi, xkunglu

Actually I am waiting for your pull request, but didn't receive any notification from GitHub. Have I missed something?

Could you please try again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ruanxiang/mr_saliency/pull/2#issuecomment-381326327, or mute the thread https://github.com/notifications/unsubscribe-auth/AjrkihQ4ZhAxOPNOoL5N7ccnynKtk0XVks5toe3BgaJpZM4TFmlu .

ruanxiang commented 6 years ago

Hi, xkunglu

Thank you for your great work!

best regards,

xkunglu commented 6 years ago

well, thank you, im just trying to make it simpler for me to use the code you built. - tested it in ubuntu 16.04 on blank conda environment, I made another pull request for simpler install, information. I havent tested it with live camera but i will, eventually - not yet as im working on other projects. xk

On Fri, Apr 20, 2018 at 2:26 AM, Xiang Ruan notifications@github.com wrote:

Hi, xkunglu

Thank you for your great work!

best regards,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ruanxiang/mr_saliency/pull/2#issuecomment-383039928, or mute the thread https://github.com/notifications/unsubscribe-auth/Ajrkime_ksWQqJa-AhSEvdPWfqA26O2wks5tqamogaJpZM4TFmlu .

ruanxiang commented 6 years ago

Thank you so much for your contribution! Just merged your push. I also add some additional explanation in README about how to install wxpython under pyenv