ruanyl / vim-fixmyjs

vim fixmyjs - auto fix your javascript using fixmyjs/eslint/tslint/jscs
MIT License
69 stars 11 forks source link

Allow using an array for g:fixmyjs_rc_filename #16

Closed fvictorio closed 7 years ago

fvictorio commented 7 years ago

This seems to work, but the code is ugly. I want to move some functions to autoload (for code organization and performance) and test it more thoroughly, but I wanted to know your thoughts on the approach.

ruanyl commented 7 years ago

Thanks for the PR, it looks good to me 👍 I added a minor opinion there, feel free to comment.

The code is quite legacy which was mainly written 2-3 years ago, so any improvements/refactors are super welcome :)

fvictorio commented 7 years ago

Sorry for taking so long to fix this. I think the scenario that you mentioned works now. Let me know if I missed something.

ruanyl commented 7 years ago

@fvictorio thanks for the updating 👍 I did a bit refactor locally and merged your commits to master, I will close the PR now.