search

ruarai / CompilePal

A tool to assist in the compiling of source engine maps
GNU General Public License v3.0
224 stars 26 forks source link

VTFs in directories containing "materials/" don't pack #102

Closed xen-000 closed 4 years ago

xen-000 commented 4 years ago

If the path to a VTF contains "materials/", it will trim out that part when parsing VMT paths, so it becomes an invalid path. For example, this VTF won't be packed:

Before parsing (not the actual path string, this is just an illustration): "materials/TopHATTwaffle-materials/brick.vtf"

After parsing: "materials/TopHATTwaffle-.vtf"

Exactol commented 4 years ago

I wasn't able to recreate this, have you tried using the latest pre release?

xen-000 commented 4 years ago

That was on the latest prerelease.

I think this is where it happens, specifically at line 334. https://github.com/ruarai/CompilePal/blob/1ba16a16d37d0d09361f2207a7d8f6363eeed74f/CompilePalX/Compilers/BSPPack/AssetUtils.cs#L329-L338

Exactol commented 4 years ago

Can you send me a material where this happens?

On Feb 11, 2020, at 7:06 PM, xen notifications@github.com wrote:

 That was on the latest prerelease.

I think this is where it happens, specifically at line 334. https://github.com/ruarai/CompilePal/blob/1ba16a16d37d0d09361f2207a7d8f6363eeed74f/CompilePalX/Compilers/BSPPack/AssetUtils.cs#L329-L338

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

xen-000 commented 4 years ago

Anything in this pack https://gamebanana.com/textures/2568

Exactol commented 4 years ago

This is now fixed: https://github.com/ruarai/CompilePal/releases/tag/v027.7