ruarai / CompilePal

A tool to assist in the compiling of source engine maps
GNU General Public License v3.0
224 stars 26 forks source link

Generate Particle Manifest creates bad paths #122

Closed bottiger1 closed 3 years ago

bottiger1 commented 4 years ago

Describe the bug If you use Generate Particle Manifest, it will create an invalid path for your particle files.

It will also pack another copy of this file with your tf2 map path.

bug

Steps to reproduce Use a particle file in your custom folder and add Utility and Generate Particle Manifest.

It will incorrectly generate this particle manifest file.

particles_manifest
{
      "file"    "!custom\ze_skyrim_v12_fix2\particles\fusrodah.pcf"
      "file"    "!custom\ze_skyrim_v12_fix2\particles\fusroderp.pcf"
}

Expected behavior

particles_manifest
{
      "file"    "particles\fusrodah.pcf"
      "file"    "particles\fusroderp.pcf"
}

debug.log

Version: v027.11

Exactol commented 3 years ago

I think this has been fixed by 1551e2e, just forgot to close the issue. If it still isn't fixed, feel free to reopen this issue.

bottiger1 commented 3 years ago

I think this has been fixed by 1551e2e, just forgot to close the issue. If it still isn't fixed, feel free to reopen this issue.

It was fixed by my commit you just merged. I tested it and it was still packing a duplicate manifest so I remade the fix in my new commit.

Relevant lines that fixed the issue:

https://github.com/ruarai/CompilePal/pull/151/files#diff-c720273f936d1e670badc91c0c3d5b23773107b3a22623278a9d4146f6ea7074R773

https://github.com/ruarai/CompilePal/pull/151/files#diff-5be67b4b7e719b87aa9f1959232670d7d3c0edb18f94bb741b622895c9878fb3R469