search

ruarai / CompilePal

A tool to assist in the compiling of source engine maps
GNU General Public License v3.0
224 stars 26 forks source link

Fixed Particle File Packing #125

Closed bottiger1 closed 3 years ago

bottiger1 commented 4 years ago

Fixes issue #122

Fixed issue with not stripping "custom/blah/" from custom/blah/particles/p.pcf.

Fixed issue with packing particle manifest files that weren't generated with compilepal when we are generating one.

Fixed issue with generated particle manifest not having a valid internal directory by switching from replace to substring. Not sure why replace didn't work, but it wasn't removing the baseDirectory and substring is more correct as it removes from the beginning of the path instead of possibly from the middle.

bottiger1 commented 3 years ago

bump @Exactol

Exactol commented 3 years ago

Sorry that I didn't accept this sooner, I thought I had left some comments on the PR. While your fix would work, it only works for particles in the Custom folder. I pushed a more generic solution in 1551e2e that would handle any mounted folder. Can you remove ParticleUtils.cs, project solution, and configuration files from the PR?

bottiger1 commented 3 years ago

You should be able to pick which parts of this commit you don't want. If you've already fixed it with your own commit then you can just close this one. I don't need the credit for it, I just want this to work for my mapping.

Exactol commented 3 years ago

Closing this PR because I'm not able to merge specific files and I'm not sure if the changes to AssetUtils are actually needed.

bottiger1 commented 3 years ago

You can pick which files you want and yes the changes are needed otherwise it will pack 2 particle manifests.