ruarai / CompilePal

A tool to assist in the compiling of source engine maps
GNU General Public License v3.0
220 stars 25 forks source link

Replace Logger #215

Open ennerperez opened 1 year ago

ennerperez commented 1 year ago

In order to simplify logger, can be a good enhancement if project use Serilog as base for all logs, all current logger functionality can be covered using serilog enrichments.

Solution: Replace CompilePalLogger with a clasic Serilog Implementation

Alternatives: NLog, Log4Net

Exactol commented 1 year ago

If I was going to start from scratch then I agree that a logging library would make more sense, but since the logger doesn't change often I don't really see how it would be beneficial

ennerperez commented 1 year ago

I understand, it just an enhancement, also I think is a good start to decoupling the dependencies in the project, avoid using a custom logger for something more flexible, CompilePalLogger is too strict to be extended, also doesn't follow the ILogger interface.

Using a custom logging library like Serilog, can enhance the way how the app writes logs, making it async, structured, standard and extensible for future developments