search

ruarai / CompilePal

A tool to assist in the compiling of source engine maps
GNU General Public License v3.0
224 stars 25 forks source link

Fix Preset Saving, T-Junction Errors, and Multi-Map Compilation #245

Open SnabbSpelare opened 2 months ago

SnabbSpelare commented 2 months ago

Is your feature request related to a problem? Please describe. Changes I make to presets in CompilePal don't save after I close the program. Also, I'm getting a 'Too many t-junctions' error that crashes the compile, and I can't easily apply settings to all maps in my list.

Describe the solution you'd like Please make presets save automatically or give a save option. Also, improve handling of t-junction errors, maybe by giving tips or letting the compile continue. I'd also like a way to apply presets to all maps at once

Describe alternatives you've considered I've tried fixing these issues manually, but it's slow and frustrating.

Additional context I've attached a screenshot

Exactol commented 2 months ago

Compile Pal is just a wrapper around the existing source engine compiling tools, the "Too many t-juncts" error is coming from the compiler and is something you need to fix. Presets not saving sounds like a bug, what version of Compile Pal are you using? Also the screenshot you attached didnt upload

SnabbSpelare commented 2 months ago

I understand that Compile Pal acts as a wrapper for compiling tools like vvis, similar to how batch scripting works, but with a GUI instead (as I see it). I think it's really neat that you've added the parameters to a list, but unfortunately, there doesn't seem to be any checks to verify if the executables support the specified parameters. Is there a reason for this? For example, the program or a batch script could run each tool with '--help' or '/?' to list all the parameters that version supports. For instance, the 64-bit version of Garry's Mod doesn't have the '-nojunc' parameter, but the 32-bit version does. However, if I use that, I think it won't remember the filenames.

Sorry, it seems I forgot to attach the screenshot by mistake. I'm using Compile Pal version 28.x4X. What should I screenshot? This was a few days ago, so I've forgotten the context.

Also, a small suggestion: it would be helpful to have the option to remove all maps in the list. For example, a button named 'Remove All' under 'Remove'. image

statecouncil commented 2 months ago

Presets not saving sounds like a bug, what version of Compile Pal are you using?

Hi, I've encountered this bug as well, and I know what causes it (me, I caused it, whoops). I'm distributing a Preset with my BAMF project and I accidentally renamed the Preset's folder (in CompilePal/Presets), but not the preset name in meta.json. If those names are not identical, apparently CompilePal does read the preset just fine but fails to write.

EDIT: As far as I'm aware, this still happens on the latest pre-release.

SnabbSpelare commented 2 months ago

Presets not saving sounds like a bug, what version of Compile Pal are you using?

Hi, I've encountered this bug as well, and I know what causes it (me, I caused it, whoops). I'm distributing a Preset with my BAMF project and I accidentally renamed the Preset's folder (in CompilePal/Presets), but not the preset name in meta.json. If those names are not identical, apparently CompilePal does read the preset just fine but fails to write.

EDIT: As far as I'm aware, this still happens on the latest pre-release.

I see, thanks for sharing! I did clone one of the default presets. Is that what you did aswell?

SnabbSpelare commented 2 months ago

New Suggestions:

  1. Skip maps causing errors. currently if you try to compile maps and just one has a error like t-junction it will completely stop processing others. this is dumb. please change this
  2. Being able to clone in Game Selector would be nice. Because for me, I need two for Garry's Mod one for GM 32 and GM 64. image
  3. Apply preset to all unselected.