Open GoogleCodeExporter opened 8 years ago
add __declspec(dllimport)/(dllexport) to class declarations
add typename to C::value_type
empty object cannot be saved or hashed on windows.it's stl's fault not my fault!
I only compile most of the ops.
some bugs remain check results.txt
Original comment by sunhaohu...@gmail.com
on 25 May 2012 at 8:39
Attachments:
ADD msvc project file
Original comment by sunhaohu...@gmail.com
on 25 May 2012 at 8:42
Attachments:
Tried to build the latest trunk with this patch in Linux and it fails:
include/IECore/IntrusivePtr.inl: In copy constructor
'IECore::IntrusivePtr<T>::IntrusivePtr(const IECore::IntrusivePtr<T>&)':
include/IECore/IntrusivePtr.inl:71: error: 'RefCounted' was not declared in
this scope
include/IECore/IntrusivePtr.inl:71: error: expected primary-expression before
')' token
include/IECore/IntrusivePtr.inl:71: error: there are no arguments to
'intrusive_ptr_add_ref' that depend on a template parameter, so a declaration
of 'intrusive_ptr_add_ref' must be available
It seems you've used 'RefCounted' class in IntrusivePtr.inl, but RefCounted.h
includes IntrusivePtr.inl itself. As RefCounted is not yet defined, gcc doesn't
like it!
Does MSVC builds it without errors?
-H
Original comment by hra...@gmail.com
on 4 Jun 2012 at 11:08
if I don't use RefCounted msvc will throw "can not convert from xxx to
RefCounted*" error when dll exporting some template class.It's really hard
to dllexport specific template class.I also want to have a better a way to
handle this.Can we add #ifndef WIN32/#endif to this?
Original comment by sunhaohu...@gmail.com
on 5 Jun 2012 at 12:23
Roberto, do you think you could create a branch (from the trunk) for this and
apply the patch to it? That way people can look at the diffs and add code
reviews very easily, and we can start to get things shaped up so they could be
merged back. From my first (admittedly quick) look at the patch, there's a fair
bit of tidying up needed before it's suitable for the trunk...
Original comment by thehaddo...@gmail.com
on 5 Jun 2012 at 4:05
i have finished this.here is my new header file
Original comment by sunhaohu...@gmail.com
on 6 Jun 2012 at 1:57
Attachments:
Yes John... I can do that. Sorry the delay in answering but I was on holiday!
I'll apply the latest IntrusivePtr.inl into the latest trunk and as soon as I
can make it build OK in linux, I'll branch it!
cheers...
-H
Original comment by hra...@gmail.com
on 26 Jun 2012 at 5:11
Original issue reported on code.google.com by
sunhaohu...@gmail.com
on 25 May 2012 at 8:37