search

rubberduck-vba / Rubberduck

Every programmer needs a rubberduck. COM add-in for the VBA & VB6 IDE (VBE).
https://rubberduckvba.com
GNU General Public License v3.0
1.91k stars 300 forks source link

App.cs does too many things #1258

Closed retailcoder closed 7 years ago

retailcoder commented 8 years ago

The constructor speaks for itself:

    public App(VBE vbe, IMessageBox messageBox,
        IRubberduckParser parser,
        IGeneralConfigService configService,
        IAppMenu appMenus,
        RubberduckCommandBar stateBar,
        IIndenter indenter,
        IRubberduckHooks hooks,
        IEnumerable<ICommand> appCommands)

Dependencies and functionality needs to be factored/regrouped into new classes.

Hosch250 commented 8 years ago

This is pretty old now. Is it cleaned up enough to suit you?

rkapka commented 7 years ago

Shouldn't this issue be closed?

retailcoder commented 7 years ago

@rkapka probably. Just took a quick look, and everything in app.cs looks like it legitimately belongs there.. except perhaps loading legacy indenter settings from the registry, but that wouldn't belong in the indenter assembly (msgbox dependency), or the shared config provider assembly (same reason).