search

rubberduck-vba / Rubberduck

Every programmer needs a rubberduck. COM add-in for the VBA & VB6 IDE (VBE).
https://rubberduckvba.com
GNU General Public License v3.0
1.92k stars 302 forks source link

Refactor|Rename dialog box will not display #4824

Closed daFreeMan closed 5 years ago

daFreeMan commented 5 years ago

Rubberduck version information The info below can be copy-paste-completed from the first lines of Rubberduck's Log or the About box:

Version 2.4.0.4565 OS: Microsoft Windows NT 10.0.15063.0, x64 Host Product: Microsoft Office 2016 x64 Host Version: 16.0.4711.1000 Host Executable: MSACCESS.EXE

Description Attempting Refactor | Rename on a cleanly compiled, freshly parsed project will not pop the dialogue box. However Refactor | Remove Parameter works just fine.

To Reproduce Steps to reproduce the behavior:

  1. Open project
  2. Compile/Parse
  3. Wait for the Ready to be displayed in the RD tool bar.
  4. Click on variable (notes that it's correctly identified in the tool bar
  5. Refactor | Rename
  6. See nothing...

Expected behavior The rename dialog box should pop

Screen Shot capture

Logfile RubberduckLog.txt

Additional context I am currently WFH using RDC to my machine at work. Not sure if that's got anything to do with it, but I could not get the log file or the screen shot to DnD into this issue, so there may be other factors at play that are preventing this from working correctly for me in this particular instance.

bclothier commented 5 years ago

Relevant error:

2019-02-25 09:14:09.6715;DEBUG-2.4.0.4565;Rubberduck.UI.Command.MenuItems.ParentMenus.ParentMenuItemBase;(60473108) Executing click handler for menu item '&Rename', hash code 55421393;
2019-02-25 09:14:09.6871;ERROR-2.4.0.4565;Rubberduck.UI.Command.Refactorings.CodePaneRefactorRenameCommand;System.ArgumentNullException: Value cannot be null.
Parameter name: source
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at System.Lazy`1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.get_Value()
   at Rubberduck.Refactorings.Rename.RenameRefactoring.NeverRenameList() in C:\projects\rubberduck\Rubberduck.Refactorings\Rename\RenameRefactoring.cs:line 581
   at Rubberduck.Refactorings.Rename.RenameRefactoring..ctor(IRefactoringPresenterFactory factory, IMessageBox messageBox, IDeclarationFinderProvider declarationFinderProvider, IProjectsProvider projectsProvider, IRewritingManager rewritingManager, ISelectionService selectionService) in C:\projects\rubberduck\Rubberduck.Refactorings\Rename\RenameRefactoring.cs:line 59
   at Rubberduck.UI.Command.Refactorings.CodePaneRefactorRenameCommand.OnExecute(Object parameter) in C:\projects\rubberduck\Rubberduck.Core\UI\Command\Refactorings\CodePaneRefactorRenameCommand.cs:line 62
   at Rubberduck.UI.Command.CommandBase.Execute(Object parameter) in C:\projects\rubberduck\Rubberduck.Core\UI\Command\CommandBase.cs:line 47;System.ArgumentNullException: Value cannot be null.
Parameter name: source
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at System.Lazy`1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.get_Value()
   at Rubberduck.Refactorings.Rename.RenameRefactoring.NeverRenameList() in C:\projects\rubberduck\Rubberduck.Refactorings\Rename\RenameRefactoring.cs:line 581
   at Rubberduck.Refactorings.Rename.RenameRefactoring..ctor(IRefactoringPresenterFactory factory, IMessageBox messageBox, IDeclarationFinderProvider declarationFinderProvider, IProjectsProvider projectsProvider, IRewritingManager rewritingManager, ISelectionService selectionService) in C:\projects\rubberduck\Rubberduck.Refactorings\Rename\RenameRefactoring.cs:line 59
   at Rubberduck.UI.Command.Refactorings.CodePaneRefactorRenameCommand.OnExecute(Object parameter) in C:\projects\rubberduck\Rubberduck.Core\UI\Command\Refactorings\CodePaneRefactorRenameCommand.cs:line 62
   at Rubberduck.UI.Command.CommandBase.Execute(Object parameter) in C:\projects\rubberduck\Rubberduck.Core\UI\Command\CommandBase.cs:line 47
comintern commented 5 years ago

Linking chat.