rubberduck-vba / Rubberduck

Every programmer needs a rubberduck. COM add-in for the VBA & VB6 IDE (VBE).
https://rubberduckvba.com
GNU General Public License v3.0
1.92k stars 302 forks source link

Stop writing ProjectID to VBProject.HelpFile #5741

Open retailcoder opened 3 years ago

retailcoder commented 3 years ago

Now that Rubberduck is loading ITypeInfo metadata from user code, we should look into whether have a better way to get a unique project ID for everything loaded in the VBE, one that doesn't involve actually persisting the ID in the host project's HelpFile property.

In fact, persisting the ID was useful for the defunct Source Control Panel circa 2015, when we needed the ID to remain the same between sessions; I don't think that's needed anymore.

retailcoder commented 3 years ago

Actually we probably don't even need the ITypeInfo API stuff for this; the sole reason for persisting the ID between sessions was for the source control panel to track the correct project even if it had the default name.

We don't need to persist it anymore; the ProjectDeclaration.ProjectId string can probably become a GUID that only needs to exist for disambiguating same-name projects in a multiple-document host.